membphis commented on a change in pull request #979: feature: support regex_uri 
option in proxy-rewrite plugin
URL: https://github.com/apache/incubator-apisix/pull/979#discussion_r362691034
 
 

 ##########
 File path: lua/apisix/plugins/proxy-rewrite.lua
 ##########
 @@ -82,6 +82,16 @@ function _M.check_schema(conf)
         return false, err
     end
 
+    if conf.regex_uri and #conf.regex_uri > 0 then
+        local _, _, err = re_sub("/fake_uri", conf.regex_uri[1],
 
 Review comment:
   
https://github.com/apache/incubator-apisix/pull/979/files#diff-0dd1fb219e34e914ab6423384290b98cR895
   
   Is this test case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to