moonming commented on a change in pull request #1370: enhance: plugin Zipkin
add service name and report local server IP
URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400053650
##########
File path: lua/apisix/plugins/zipkin.lua
##########
@@ -109,6 +130,10 @@ function _M.rewrite(conf, ctx)
local request_span = ctx.opentracing.request_span
ctx.opentracing.rewrite_span = request_span:start_child_span(
"apisix.rewrite", start_timestamp)
+
+ ctx.opentracing.rewrite_span:set_tag("peer.service",conf.service_name)
Review comment:
add space after comma
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
