moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400606628
########## File path: lua/apisix/plugins/zipkin.lua ########## @@ -94,6 +99,8 @@ function _M.rewrite(conf, ctx) -- TODO: support ipv6 ["peer.ipv4"] = core.request.get_remote_client_ip(ctx), ["peer.port"] = core.request.get_remote_client_port(ctx), + ["peer.service"] = conf.service_name, + ["local.ip"] = ctx.var.server_addr, Review comment: can we add test cases for that? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services