tokers commented on code in PR #278: URL: https://github.com/apache/apisix-helm-chart/pull/278#discussion_r940117099
########## charts/apisix/values.yaml: ########## @@ -121,11 +121,10 @@ nameOverride: "" fullnameOverride: "" serviceAccount: - create: true + create: false # Set to `true` to create ServiceAccount for Kubernetes service discovery. Review Comment: I want to know why you change the default value. It's a broken change. ########## charts/apisix/values.yaml: ########## @@ -290,26 +293,42 @@ extraVolumeMounts: [] discovery: enabled: false - registry: - # Integration service discovery registry. E.g eureka\dns\nacos\consul_kv - # reference: - # https://apisix.apache.org/docs/apisix/discovery#configuration-for-eureka - # https://apisix.apache.org/docs/apisix/discovery/dns#service-discovery-via-dns - # https://apisix.apache.org/docs/apisix/discovery/consul_kv#configuration-for-consul-kv - # https://apisix.apache.org/docs/apisix/discovery/nacos#configuration-for-nacos - # - # an eureka example: - # eureka: - # host: - # - "http://${username}:${password}@${eureka_host1}:${eureka_port1}"; - # - "http://${username}:${password}@${eureka_host2}:${eureka_port2}"; - # prefix: "/eureka/" - # fetch_interval: 30 - # weight: 100 - # timeout: - # connect: 2000 - # send: 2000 - # read: 5000 + registry: {} + # Integration service discovery registry. E.g eureka\dns\nacos\consul_kv + # reference: + # https://apisix.apache.org/docs/apisix/discovery/#configuration-for-eureka + # https://apisix.apache.org/docs/apisix/discovery/dns/#service-discovery-via-dns + # https://apisix.apache.org/docs/apisix/discovery/consul_kv/#configuration-for-consul-kv + # https://apisix.apache.org/docs/apisix/discovery/nacos/#configuration-for-nacos + # https://apisix.apache.org/docs/apisix/discovery/kubernetes/#configuration + # + # an eureka example: + # ``` + # eureka: + # host: + # - "http://${username}:${password}@${eureka_host1}:${eureka_port1}"; + # - "http://${username}:${password}@${eureka_host2}:${eureka_port2}"; + # prefix: "/eureka/" + # fetch_interval: 30 + # weight: 100 + # timeout: + # connect: 2000 + # send: 2000 + # read: 5000 + # ``` + # + # the minimal Kubernetes example: + # ``` + # kubernetes: {} + # ``` + # + # The prerequisites for the above minimal Kubernetes example: + # 1. Set `.serviceAccount.create` (L124) to `true` to create the ServiceAccount with required permissions. + # This is for allowing the default `.discovery.registry.kubernetes.client.token_file`. + # 2. Add the following environment variables into `.nginx.envs` (L196) to pass into nginx worker processes: + # - KUBERNETES_SERVICE_HOST + # - KUBERNETES_SERVICE_PORT + # This is for allowing the default `host` and `port` of `.discovery.registry.kubernetes.service`. Review Comment: OK. Just ignore it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
