tokers commented on code in PR #278: URL: https://github.com/apache/apisix-helm-chart/pull/278#discussion_r940797212
########## charts/apisix/templates/clusterrole.yaml: ########## @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +{{- $kubernetesTokenFile := "/var/run/secrets/kubernetes.io/serviceaccount/token" -}} +{{- $create := false -}} +{{- if .Values.discovery.enabled -}} +{{- with .Values.discovery.registry -}} +{{- if hasKey . "kubernetes" -}} +{{- if .kubernetes.client -}} +{{- if eq .kubernetes.client.token_file $kubernetesTokenFile -}} +{{- $create = true -}} Review Comment: I thought for a while, and I think maybe a custom token path is not useful when users deploy Apache APISIX on Kubernetes, what they want is a custom token, the path is not critical. So as long as users can mount the custom token, the purpose can be achieved. So what we can do is support mount a custom serviceaccount. This PR is large enough, l just add another issue https://github.com/apache/apisix-helm-chart/issues/322 to track it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
