lzxuan commented on code in PR #278: URL: https://github.com/apache/apisix-helm-chart/pull/278#discussion_r940275359
########## charts/apisix/templates/clusterrole.yaml: ########## @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +{{- $kubernetesTokenFile := "/var/run/secrets/kubernetes.io/serviceaccount/token" -}} +{{- $create := false -}} +{{- if .Values.discovery.enabled -}} +{{- with .Values.discovery.registry -}} +{{- if hasKey . "kubernetes" -}} +{{- if .kubernetes.client -}} +{{- if eq .kubernetes.client.token_file $kubernetesTokenFile -}} +{{- $create = true -}} Review Comment: Actually, my idea is to provide the flexibility for users to decide whether or not to use the kubernetes service account token file. In case users want to use it, we generate the RBAC. Otherwise, users might want to mount other tokens using e.g. Secret to a specific path, in which the RBAC is not needed to be generated. In this case, users will need to configure the custom tokens to be used in prior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
