lzxuan commented on code in PR #278:
URL: https://github.com/apache/apisix-helm-chart/pull/278#discussion_r942487671
##########
charts/apisix/templates/deployment.yaml:
##########
@@ -45,6 +45,7 @@ spec:
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
+ serviceAccountName: {{ include "apisix.serviceAccountName" . }}
Review Comment:
I belief the helper template already included the necessary checking? If
serviceAccount is not created, it will use the default "default" service
account. I see most of the helm charts using it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
