Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r471392464



##########
File path: apisix/core.lua
##########
@@ -19,7 +19,9 @@ local local_conf = 
require("apisix.core.config_local").local_conf()
 
 local config_center = local_conf.apisix and local_conf.apisix.config_center
                       or "etcd"
+local etcd_version = local_conf.etcd.version == "v3" and "_v3" or ""

Review comment:
       Currently, the implementation is to use v2 as the default, and user 
would change to v3 if needed. Of course we can use v3 as default.
   
   ping @nic-chen @membphis maybe we need to discuss about it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to