Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r471395590



##########
File path: conf/config.yaml
##########
@@ -129,6 +129,8 @@ etcd:
     - "http://127.0.0.1:2379";     # multiple etcd address
   prefix: "/apisix"               # apisix configurations prefix
   timeout: 30                     # 30 seconds
+  version: "v3"                   # etcd version: v2/v3
+  api_prefix: "/v3alpha"          # 3.2 -> "/v3alpha", 3.3 -> "/v3beta", 3.4+ 
-> "/v3"

Review comment:
       api_prefix has implemented to be detectd and set by lua code, as changed 
in 
[t/APISIX.pm](https://github.com/apache/apisix/blob/97809d8fabf29e78d5470835f8f53888bcb2f23e/t/APISIX.pm#L83).
 
   I could remove it and move those lua code to etcd_v3.lua if needed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to