juzhiyuan commented on a change in pull request #395:
URL: https://github.com/apache/apisix-dashboard/pull/395#discussion_r475689172
##########
File path: src/pages/SSL/locales/en-US.ts
##########
@@ -15,39 +15,41 @@
* limitations under the License.
*/
export default {
- 'ssl.form.expiration.time':'Expiration Time',
- 'ssl.form.public.key':'Public Key',
+ 'ssl.form.expiration.time': 'Expiration Time',
+ 'ssl.form.cert': 'Cert',
Review comment:
I think. using the public key is more straightforward than Cert,
@moonming how about you?
##########
File path: src/pages/SSL/locales/en-US.ts
##########
@@ -15,39 +15,41 @@
* limitations under the License.
*/
export default {
- 'ssl.form.expiration.time':'Expiration Time',
- 'ssl.form.public.key':'Public Key',
+ 'ssl.form.expiration.time': 'Expiration Time',
+ 'ssl.form.cert': 'Cert',
'ssl.form.check.cert.value': 'Please check Cert value',
'ssl.form.cert.value.length': 'The Cert value requires at least 128
characters',
- 'ssl.form.private.key':'Private Key',
+ 'ssl.form.private.key': 'Private Key',
'ssl.form.check.key.value': 'Please check Key value',
'ssl.form.key.value.length': 'The Key value requires at least 128
characters',
- 'ssl.upload.public.key':'Upload Public Key',
- 'ssl.upload.private.key':'Upload Private Key',
+ 'ssl.upload.cert': 'Upload Cert',
+ 'ssl.upload.private.key': 'Upload Private Key',
- 'ssl.step.way':'Way',
- 'ssl.step.rules':'The new certificate should contain the same about SNI as
the current certificate',
- 'ssl.step.select.create.ways':'Please select create ways',
- 'ssl.step.input':'Input',
- 'ssl.step.upload':'Upload',
+ 'ssl.step.way': 'Way',
+ 'ssl.step.rules':
+ 'The new certificate should contain the same about SNI as the current
certificate',
+ 'ssl.step.select.create.ways': 'Please select create ways',
Review comment:
methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
