juzhiyuan commented on a change in pull request #395:
URL: https://github.com/apache/apisix-dashboard/pull/395#discussion_r476092581
##########
File path: src/pages/SSL/locales/en-US.ts
##########
@@ -15,39 +15,41 @@
* limitations under the License.
*/
export default {
- 'ssl.form.expiration.time':'Expiration Time',
- 'ssl.form.public.key':'Public Key',
+ 'ssl.form.expiration.time': 'Expiration Time',
+ 'ssl.form.cert': 'Cert',
Review comment:
`cert` contains both Public and Private key and other information of
course, so I don't think it's a good idea to use the `cert` as form field's
name :C
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
