AlinsRan commented on code in PR #1576:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1576#discussion_r1060316358
##########
pkg/providers/ingress/translation/translator.go:
##########
@@ -356,7 +356,7 @@ func (t *translator)
translateDefaultUpstreamFromIngressV1(namespace string, bac
ups.ID = id.GenID(ups.Name)
return ups
}
-func (t *translator) translateUpstreamFromIngressV1(namespace string, backend
*networkingv1.IngressServiceBackend) (*apisixv1.Upstream, error) {
+func (t *translator) translateUpstreamFromIngressV1(namespace string, backend
*networkingv1.IngressServiceBackend, eventType types.EventType)
(*apisixv1.Upstream, error) {
var svcPort int32
if backend.Port.Name != "" {
Review Comment:
If `backend.port.name` is used here, it will cause repeated attempts,
including use cases where endpoints do not exist.
I recommend implementing this method
https://github.com/apache/apisix-ingress-controller/commit/486b46abd1c9665005e83036433af213aaa28f21
instead of passing parameters to cause logic coupling
*
##########
pkg/providers/ingress/translation/translator.go:
##########
@@ -356,7 +356,7 @@ func (t *translator)
translateDefaultUpstreamFromIngressV1(namespace string, bac
ups.ID = id.GenID(ups.Name)
return ups
}
-func (t *translator) translateUpstreamFromIngressV1(namespace string, backend
*networkingv1.IngressServiceBackend) (*apisixv1.Upstream, error) {
+func (t *translator) translateUpstreamFromIngressV1(namespace string, backend
*networkingv1.IngressServiceBackend, eventType types.EventType)
(*apisixv1.Upstream, error) {
var svcPort int32
if backend.Port.Name != "" {
Review Comment:
If `backend.port.name` is used here, it will cause repeated attempts,
including use cases where endpoints do not exist.
I recommend implementing this method
https://github.com/apache/apisix-ingress-controller/commit/486b46abd1c9665005e83036433af213aaa28f21
instead of passing parameters to cause logic coupling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
