heresie opened a new pull request, #528:
URL: https://github.com/apache/apisix-helm-chart/pull/528

   Hello everybody 👋
   
   I'm currently trying to install APISIX on Kubernetes clusters that need to 
use Proxy Protocol in order to be usable. Unfortunately, the current Helm Chart 
does not allow to configure APISIX with proxy protocol by using `values.yaml` 
configuration.
   
   The previous PR #353 about this subject is getting old, and @hgranillo has 
moved from APISIX, so here is a new one, updated and ready to merge.
   
   I tested this Chart update on our K8S clusters, without any problem.
   
   As stated in the original PR :
   
   > This PR adds the option to enable Proxy Protocol in the APISIX 
configuration file and allows to add the proxy protocol listeners to the 
gateway Kubernetes service.
   > 
   > Made all ports configurable in a fashion similar to `apisix-gateway` and 
`apisix-gateway-tls`.
   > 
   > I left `enable_tcp_pp_to_upstream` out because at this moment I have no 
way to test it. I can add the toggle if needed to merge this PR.
   > 
   > I tested these changes with the following configuration in one of my EKS 
Clusters.
   > I'm using the 
[aws-load-balancer-controller](https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.4/)
 to provision a NBL with SSL/TLS Offloading and Proxy Protocol enabled (see 
loadbalancer annotations below)
   > 
   > This allows me to send HTTP(80) -> ProxyProtocol HTTP(9181) and HTTPS 443 
-> ProxyProtocol HTTP (9181)
   
   Here is the `values.yaml` I used for tests :
   
   ```yaml
   global:
     enableIPv6: false
     storageClass: <my-storage-class>
   
   apisix:
     kind: DaemonSet
     proxyProtocol:
       enabled: true
       listenHttpPort: 9181
       listenHttpsPort: 9182
   
   gateway:
     type: NodePort
     http:
       enabled: true
     tls:
       enabled: true
     proxyProtocol:
       http:
         enabled: true
         nodePort: 30080
         containerPort: 9181
       https:
         enabled: true
         nodePort: 30443
         containerPort: 9182
   ```
   
   This PR also bumps Chart Version to the next minor : `1.4.0`.
   
   All comments are welcome.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to