fengxsong commented on PR #9194:
URL: https://github.com/apache/apisix/pull/9194#issuecomment-1508145751

   > I don't understand why the none_match_abort parameter should be added, the 
proxy-rewrite plugin should not be able to block the request
   
   There are some scenarios we don't want to expose all of our APIs, for 
example.
   
   ```
         match:
           hosts:
           - echo.example.local
           paths:
           - /v1/user/*
         name: echo
         plugins:
         - config:
             none_match_abort: true
             regex_uri:
             - /v1/user/([:A-Za-z0-9_-]+)/follow
             - /api/v1/user/$1/follow
             - /v1/user/([:A-Za-z0-9_-]+)/comment
             - /api/v1/user/$1/comment
           enable: true
           name: proxy-rewrite
   ```
   
   we can only expose `/v1/user/([:A-Za-z0-9_-]+)/follow` and 
`/v1/user/([:A-Za-z0-9_-]+)/comment`, and hide the rest API endpoints.
   
   From the point of view of ability classification, `none_match_abort` 
shouldn't be here. so this might needs more discussions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to