kingluo commented on code in PR #9909: URL: https://github.com/apache/apisix/pull/9909#discussion_r1293182074
########## apisix/core/config_etcd.lua: ########## @@ -257,6 +260,30 @@ local function run_watch(premature) end +local function run_watch(premature) + ::restart:: Review Comment: > What if the thread `do_run_watch` crashes? It's not supposed to crash. In fact, almost all timers did not have a crash guard. And even if run_watch crashes, you cannot fix it by restarting it, 'cause it's a stateful routine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
