kingluo commented on code in PR #9909: URL: https://github.com/apache/apisix/pull/9909#discussion_r1293163630
########## apisix/core/config_etcd.lua: ########## @@ -257,6 +260,30 @@ local function run_watch(premature) end +local function run_watch(premature) + ::restart:: Review Comment: **No! The watch routine must not be restarted!** Because it's a stateful routine (e.g. last watch starts revision) and should start once and notify all child watchers that it started. @jiangfucheng **Instead, you just wait for check_worker_th, if it exits, it means the worker process is exiting, then kill run_watch_th, and that's it.** Please make a change again on the code, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
