kingluo commented on PR #9930:
URL: https://github.com/apache/apisix/pull/9930#issuecomment-1688170149

   The code is fine with me.
   
   But I think it should be noted in the PR description which configuration 
fields support encryption:
   * [x] Admin Key
   * [x] Admin API certificate
   * [ ] etcd password
   * [ ] etcd certificate
   * [ ] information that may exist in the plugin_attr
   
   Also, whether in this PR or not, the relevant documentation should also 
describe this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to