AlinsRan commented on code in PR #1803: URL: https://github.com/apache/apisix-ingress-controller/pull/1803#discussion_r1305095446
########## conf/apisix-schema.json: ########## Review Comment: Maintenance can be done through diff [https://apisix.apache.org/zh/docs/apisix/control-api/#get-v1schema ](https://apisix.apache.org/zh/docs/apisix/control-api/#get-v1schema) . Using files instead of APIs, there are 3 considerations 1. DP API only supports getting schema, does not support validate, still need to verify in CP. 2. In a separate schema for DP and CP, get the json schema to validate the CRD, which will cause CP to depend on DP. 3. Since the json schema cannot modify instances and inject some default values, there are some schemas that cannot be used directly, including the limit-count plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
