[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1803: feat: support controller as etcd server

Mon, 28 Aug 2023 22:57:46 -0700 


AlinsRan commented on code in PR #1803:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/1803#discussion_r1308248340


##########
test/e2e/scaffold/apisix.go:
##########
@@ -46,7 +46,7 @@ spec:
       app: apisix-deployment-e2e-test
   strategy:
     rollingUpdate:
-      maxSurge: 50%
+      maxSurge: 50%%

Review Comment:
   No, if you want to output a string using format characters, you need to use 
%% to represent the percentage sign.
   
![image](https://github.com/apache/apisix-ingress-controller/assets/79972061/92cb98c6-76df-4d36-92c6-f81a87e80eef)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to