gxthrj commented on pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#issuecomment-697198175


   > @imjoey One thing confuses me that the labels field is attached on the 
whole `upstream` object, It's closer to the labels on Kubernetes Service, not 
the Pod, and labels on Pod are more pragmatic, so what about attaching labels 
for each node in this upstream, with this support, we can group the nodes by 
labels, and in turn implementing some features like blue green release, canary 
release or other route rules.
   
   Your idea is great,
   But we also need to pay attention to the structure of APISIX, 
   1. The `nodes` under `upstream` is not an object yet;
   2. Blue-green or canary releases are more tied to business, not suitable for 
writing in upstream objects, but more suitable for extension in plug-ins, But 
upstream currently does not provide any plug-in implementation;
   if we add labels in nodes, I think it will be a big change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to