imjoey commented on a change in pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#discussion_r493305139
##########
File path: apisix/schema_def.lua
##########
@@ -332,6 +332,10 @@ local upstream_schema = {
description = "enable websocket for request",
type = "boolean"
},
+ labels = {
+ description = "key/value pairs to specify attributes",
+ type = "table"
Review comment:
@membphis agreed, nice catch, thanks. I would make changes as the your
suggestions and add one more failure test case after I find the lua way. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
