imjoey commented on a change in pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#discussion_r494888017
##########
File path: apisix/schema_def.lua
##########
@@ -332,6 +332,10 @@ local upstream_schema = {
description = "enable websocket for request",
type = "boolean"
},
+ labels = {
+ description = "key/value pairs to specify attributes",
Review comment:
Hi @membphis @nic-chen @gxthrj , PR is updated and the format of value
in `labels` is limited to `string`, with set maxProperties to 16. A new test
case which contains invalid value format is also added. Feel free to leave your
comments. Thanks.
##########
File path: apisix/schema_def.lua
##########
@@ -332,6 +332,10 @@ local upstream_schema = {
description = "enable websocket for request",
type = "boolean"
},
+ labels = {
+ description = "key/value pairs to specify attributes",
+ type = "table"
Review comment:
@membphis PR is updated and labels are limited to string key/value
pairs, so fix the depth problem. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
