bzp2010 commented on code in PR #10550:
URL: https://github.com/apache/apisix/pull/10550#discussion_r1419912672
##########
ci/centos7-ci.sh:
##########
@@ -41,11 +41,15 @@ install_dependencies() {
# install openresty to make apisix's rpm test work
yum install -y yum-utils && yum-config-manager --add-repo
https://openresty.org/package/centos/openresty.repo
wget
"https://raw.githubusercontent.com/api7/apisix-build-tools/apisix-runtime/${APISIX_RUNTIME}/build-apisix-runtime-debug-centos7.sh";
- wget
"https://raw.githubusercontent.com/api7/apisix-build-tools/apisix-runtime/${APISIX_RUNTIME}/build-apisix-runtime.sh";
+ #wget
"https://raw.githubusercontent.com/api7/apisix-build-tools/apisix-runtime/${APISIX_RUNTIME}/build-apisix-runtime.sh";
+ wget
https://raw.githubusercontent.com/Sn0rt/apisix-build-tools/guohao/update-lua-resty-events/build-apisix-runtime.sh
chmod +x build-apisix-runtime-debug-centos7.sh
chmod +x build-apisix-runtime.sh
./build-apisix-runtime-debug-centos7.sh
+ # patch lua-resty-events
Review Comment:
It is impossible to execute a reload without a transient interruption
because the worker that was handling the unix socket connection is being
restarted, and the other workers will not be able to connect to the broker over
the unix socket again until the new worker that replaces it is up and running,
so the logs will be some error level logs about connection closed, which will
interrupt our tests, so we'll have to change the code here to warn level.
There is no need to apply this patch in production as it has no impact other
than causing some error logs, when the worker is available, the worker and
broker will reconnect, and event push will be available again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
