bzp2010 commented on code in PR #10550:
URL: https://github.com/apache/apisix/pull/10550#discussion_r1420061307


##########
ci/redhat-ci.sh:
##########
@@ -94,7 +100,7 @@ run_case() {
     make init
     set_coredns
     # run test cases
-    FLUSH_ETCD=1 prove --timer -Itest-nginx/lib -I./ -r ${TEST_FILE_SUB_DIR} | 
tee /tmp/test.result
+    FLUSH_ETCD=1 TEST_EVENTS_MODULE=lua-resty-worker-events prove --timer 
-Itest-nginx/lib -I./ -r ${TEST_FILE_SUB_DIR} | tee /tmp/test.result

Review Comment:
   First, this is the same logic executed in the other test scripts, with the 
difference that under ubuntu we are executing the tests for both event modules 
at the same time, where an environment variable controlled by GitHub workflow 
is used as input.
   
   You can see the header of some of the test cases, some of the tests are 
related to the events library and because of the implementation of the library 
they have slightly different behaviors, such as proactive health checks, which 
use different test cases under different events modules.
   
   If an events module is not explicitly configured, it will default to the 
value in config-default, which is lua-resty-events, so simultaneous testing is 
not possible.
   
   But it looks like some of the logic can be ported to APISIX.pm, and I'll be 
making that change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to