bzp2010 commented on code in PR #10550: URL: https://github.com/apache/apisix/pull/10550#discussion_r1420073706
########## t/node/healthcheck-discovery.t: ########## @@ -153,8 +156,6 @@ qr/(create new checker|try to release checker): table/ create new checker: table try to release checker: table create new checker: table ---- no_error_log Review Comment: They should have no impact because the main use of the test is to test that when the service discovers a change in the node provided, the new checker is created correctly rather than as a result of a health check. If you are concerned about this, we will have to follow the example of the passive health check tests by listing them as separate test files and skipping them when they are not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
