lucasarnulphy commented on PR #11445: URL: https://github.com/apache/apisix/pull/11445#issuecomment-2257781069
I think you might be right about returning more info, but I'm not sure it should be exclusive. Many systems just read a single header with a username and then build all permissions on that. Returning a lot of information in a single header would make that harder to implement. I do agree it would be great for the upstreams to have more information, maybe as a UserInfo header as it is done in the openid connect plugin, I'll probably implement that next. As far as tests are concerned... it's only a few lines of codes to return a variable that was already stored and tested before, so I think we're in the clear... but I'll let you be the judge of that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org