beardnick commented on code in PR #11824:
URL: https://github.com/apache/apisix/pull/11824#discussion_r2146686330


##########
apisix/plugins/openid-connect.lua:
##########
@@ -331,6 +339,7 @@ local _M = {
     schema = schema,
 }
 
+local generic_claim_validator = nil;

Review Comment:
   > Is it possible to avoid using global variables?
   
   There seems to be no better way to handle this situation. I scanned the 
codebase, and the ai.lua seems to have done a similar thing.
   
https://github.com/beardnick/apisix/blob/3e5e0ebd1eb94f13dd110b2404ab702ce2835286/apisix/plugins/ai.lua#L34-L35



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to