nic-6443 commented on code in PR #12353:
URL: https://github.com/apache/apisix/pull/12353#discussion_r2158493058
##########
apisix/discovery/nacos/init.lua:
##########
@@ -417,7 +363,20 @@ end
function _M.dump_data()
- return {config = local_conf.discovery.nacos, services = applications or {}}
+ local keys = nacos_dict:get_keys(0)
+ local applications = {}
+ for _, key in ipairs(keys) do
+ local value = nacos_dict:get(key)
+ if value then
+ local nodes = core.json.decode(value)
+ if nodes and #nodes > 0 then
Review Comment:
`dump_data` is for debug purpose, if value in shared dict for this key is
empty , we should return the real empty value for debugging instead hide it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
