bzp2010 commented on code in PR #12353:
URL: https://github.com/apache/apisix/pull/12353#discussion_r2163363557
##########
apisix/discovery/nacos/init.lua:
##########
@@ -371,40 +348,18 @@ function _M.nodes(service_name, discovery_args)
discovery_args.namespace_id or default_namespace_id
local group_name = discovery_args
and discovery_args.group_name or default_group_name
-
- local logged = false
- -- maximum waiting time: 5 seconds
- local waiting_time = 5
- local step = 0.1
- while not applications and waiting_time > 0 do
- if not logged then
- log.warn('wait init')
- logged = true
- end
- ngx.sleep(step)
- waiting_time = waiting_time - step
- end
-
- if not applications or not applications[namespace_id]
- or not applications[namespace_id][group_name]
- then
+ local key = get_key(namespace_id, group_name, service_name)
+ local value = nacos_dict:get(key)
Review Comment:
When we encounter performance issues, consider adding caching with TTL at
the worker level to further improve locality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
