Baoyuantop commented on code in PR #11629: URL: https://github.com/apache/apisix/pull/11629#discussion_r2165474675
########## t/plugin/opa3.t: ########## @@ -0,0 +1,96 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +use t::APISIX 'no_plan'; + +repeat_each(1); +no_long_string(); +no_root_location(); + +add_block_preprocessor(sub { + my ($block) = @_; + + if (!defined $block->request) { + $block->set_value("request", "GET /t"); + } +}); + +run_tests(); + +__DATA__ + +=== TEST 1: setup route with plugin +--- config + location /t { + content_by_lua_block { + local t = require("lib.test_admin").test + local code, body = t('/apisix/admin/routes/1', + ngx.HTTP_PUT, + [[{ + "methods": ["POST"], + "plugins": { + "opa": { + "host": "http://127.0.0.1:8181";, + "policy": "with_body", + "with_body": true + } + }, + "upstream": { + "nodes": { + "127.0.0.1:1980": 1 + }, + "type": "roundrobin" + }, + "uris": ["/hello", "/test"] + }]] + ) + + if code >= 300 then + ngx.status = code + end + ngx.say(body) + } + } +--- response_body +passed + + + +=== TEST 2: hit route (with empty request) +--- request +POST /hello +--- response_body +hello world + + + +=== TEST 3: hit route (with json request) +--- request +POST /hello +{ + "hello": "world" +} +--- response_body +hello world + + + +=== TEST 4: hit route (with non-json request) +--- request +POST /hello +hello world +--- response_body +hello world Review Comment: We need to verify the body data received by OPA during the test. ########## docs/en/latest/plugins/opa.md: ########## @@ -46,6 +46,7 @@ The `opa` Plugin can be used to integrate with [Open Policy Agent (OPA)](https:/ | with_route | boolean | False | false | | When set to true, sends information about the current Route. | Review Comment: Need to modify Chinese documents synchronously ########## docs/en/latest/plugins/opa.md: ########## @@ -46,6 +46,7 @@ The `opa` Plugin can be used to integrate with [Open Policy Agent (OPA)](https:/ | with_route | boolean | False | false | | When set to true, sends information about the current Route. | | with_service | boolean | False | false | | When set to true, sends information about the current Service. | | with_consumer | boolean | False | false | | When set to true, sends information about the current Consumer. Note that this may send sensitive information like the API key. Make sure to turn it on only when you are sure it is safe. | +| with_body | boolean | False | false | | When set to true, sends the request body. | Review Comment: The request body may contain sensitive information (passwords, API keys, etc.), so a security warning needs to be added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
