Copilot commented on code in PR #2460:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2460#discussion_r2188825761
##########
internal/provider/adc/executor.go:
##########
@@ -51,15 +52,26 @@ func (e *DefaultADCExecutor) Execute(ctx context.Context,
mode string, config ad
}
func (e *DefaultADCExecutor) runADC(ctx context.Context, mode string, config
adcConfig, args []string) error {
- var failedAddrs []string
+ var execErrs = types.ADCExecutionError{
Review Comment:
In `runADC`, you collect multiple server errors into a single
`ADCExecutionError` but later the sync logic expects an `ADCExecutionErrors`
(plural) wrapper. Consider changing `execErrs` to type `ADCExecutionErrors` so
downstream `errors.As` checks correctly detect all failures.
```suggestion
var execErrs = types.ADCExecutionErrors{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
