jizhuozhi commented on PR #12448:
URL: https://github.com/apache/apisix/pull/12448#issuecomment-3116500881

   Hello, @Baoyuantop, thanks for your reply. 
   
   > Hi @jizhuozhi, There is currently no modification to the upstream schema, 
which means that the current modifications in the upstream only serve consul. 
Is it more appropriate to put all these logics into the consul module?
   
   Not only consul, but also Eureka (which has already supported metadata) will 
inherit this function. In my forked dashboard has already supported configuring 
metadata_match for Consul and Eureka
   
   
https://github.com/jizhuozhi/apisix-dashboard/blob/9bd72c82e4fcbfa0d2bf34420280028c2ca853c8/web/src/components/Upstream/components/ServiceDiscovery.tsx#L29-L42
   
   And the current discovery package is responsible for pulling all instances, 
and the filtering in discovery is effective for all service names and 
upstreams, it means that I can only configure general filtering rules, but 
cannot configure differentiated matching for different routes and upstreams.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to