SkyeYoung commented on code in PR #12448:
URL: https://github.com/apache/apisix/pull/12448#discussion_r2244647074
##########
apisix/discovery/consul/init.lua:
##########
@@ -532,7 +541,8 @@ function _M.connect(premature, consul_server, retry_delay)
core.table.insert(nodes, {
host = svc_address,
port = tonumber(svc_port),
- weight = default_weight,
+ weight = metadata and tonumber(metadata.weight) or
default_weight,
Review Comment:
IMO, even though this is a common practice, I think we should initiate
another discussion and submit a separate PR to adjust it. Because this doesn't
seem to be related to the PR title (if the title represents the topic of this
PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
