membphis commented on code in PR #12465:
URL: https://github.com/apache/apisix/pull/12465#discussion_r2244991404
##########
apisix/plugins/workflow.lua:
##########
@@ -116,10 +120,20 @@ function _M.check_schema(conf)
for idx, rule in ipairs(conf.rules) do
if rule.case then
- local ok, err = expr.new(rule.case)
+ local expr, err = expr.new(rule.case)
if not ok then
return false, "failed to validate the 'case' expression: " ..
err
end
+ local mt = getmetatable(rule)
+ if not mt then
+ mt = {}
+ setmetatable(rule, mt)
+ end
+ mt.__index = function (_, key)
Review Comment:
this way is much better to read:
```
local my_table = {b="b"}
local meta = getmetatable(my_table)
if not meta then
meta = {}
meta.__index = meta
setmetatable(my_table, meta)
end
meta.a = "a"
print(my_table.a)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
