AlinsRan commented on code in PR #2577:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2577#discussion_r2381675682
##########
internal/adc/translator/apisixroute.go:
##########
@@ -269,7 +269,7 @@ func (t *Translator) buildUpstream(tctx
*provider.TranslateContext, service *adc
}
// no valid upstream
- if len(upstreams) == 0 || len(upstreams[0].Nodes) == 0 {
+ if len(upstreams) == 0 {
Review Comment:
Why shouldn't it be?
Assuming that in a grayscale scenario, service a may be unavailable, but
service b is available, I think this judgment is unreasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
