ronething commented on code in PR #2577:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2577#discussion_r2381549790
##########
internal/adc/translator/apisixroute.go:
##########
@@ -269,7 +269,7 @@ func (t *Translator) buildUpstream(tctx
*provider.TranslateContext, service *adc
}
// no valid upstream
- if len(upstreams) == 0 || len(upstreams[0].Nodes) == 0 {
+ if len(upstreams) == 0 {
Review Comment:
Should we first check whether `Nodes` or `discovery type` exist before
adding a single upstream to the upstreams array? If neither exists, should we
not add it to the upstreams array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
