AlinsRan commented on code in PR #2592:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2592#discussion_r2425267968
##########
internal/adc/translator/gateway.go:
##########
@@ -122,8 +120,7 @@ func (t *Translator) translateSecret(tctx
*provider.TranslateContext, listener g
}
sslObj.Snis = append(sslObj.Snis,
hosts...)
}
- // Note: use cert as id to avoid duplicate
certificate across ssl objects
- sslObj.ID = id.GenID(string(cert))
+ sslObj.ID =
id.GenID(fmt.Sprintf("Gateway_%s_%s_%s_%d", obj.Namespace, obj.Name,
listener.Name, refIndex))
Review Comment:
I think choosing 1 between `listener.name` and `refIndex` is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
