AlinsRan commented on code in PR #2592:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2592#discussion_r2425278173
##########
internal/adc/translator/ingress.go:
##########
@@ -64,7 +64,7 @@ func (t *Translator) translateIngressTLS(ingressTLS
*networkingv1.IngressTLS, se
},
Snis: hosts,
}
- ssl.ID = id.GenID(string(cert))
+ ssl.ID = id.GenID(fmt.Sprintf("Ingress_%s_%s_%d", namespace, name,
tlsIndex))
Review Comment:
The name generation is universal, and I think it can be abstracted as the
composeName function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
