guilbill commented on code in PR #12643:
URL: https://github.com/apache/apisix/pull/12643#discussion_r2390211294


##########
powered-by.md:
##########
@@ -65,6 +65,7 @@ Users are encouraged to add themselves to this page, 
[issue](https://github.com/
 1. <a href="https://www.jpl.nasa.gov"; rel="nofollow">NASA JPL 美国国家航空航天局 
喷气推进实验室</a>
 1. <a href="https://www.purcotton.com/"; rel="nofollow">Purcotton 
深圳全棉时代科技有限公司</a>
 1. <a href="https://www.360.cn/"; rel="nofollow">360 奇虎</a>
+1. <a href="https://marmelab.com/react-admin/AuthProviderList.html"; 
rel="nofollow">React-admin</a>

Review Comment:
   I wasn't sure what to link... React-admin is a frontend framework for 
building B2B applications with React. It works with data providers to plug the 
admin to an api, and auth providers to plug the admin to whatever can handle 
authentication. One of the Auth-providers is @arte/ra-apisix-oidc that allows 
you to use apisix authentication.
   
   So as I found that linking to React-admin homepage would be confusing, I 
choosed to link to the documentation refering to the authProvider list, where 
you can see the Apisix one.
   
   Is it clearer and does it seems relevant ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to