Baoyuantop commented on code in PR #12734: URL: https://github.com/apache/apisix/pull/12734#discussion_r2570810327
########## apisix/discovery/nacos/init.lua: ########## @@ -195,6 +191,21 @@ local function get_base_uri() end +local function get_base_uri_by_index(index) + local host = local_conf.discovery.nacos.host + if type(host) ~= 'table' then + return nil Review Comment: I opted out of that check; it felt a bit unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
