Baoyuantop commented on code in PR #12734:
URL: https://github.com/apache/apisix/pull/12734#discussion_r2570811122
##########
apisix/discovery/nacos/init.lua:
##########
@@ -277,69 +288,118 @@ local function is_grpc(scheme)
end
local curr_service_in_use = {}
-local function fetch_full_registry(premature)
- if premature then
- return
- end
- local base_uri, username, password = get_base_uri()
+
+local function fetch_from_host(base_uri, username, password, services)
local token_param, err = get_token_param(base_uri, username, password)
if err then
- log.error('get_token_param error:', err)
- return
+ return false, err
end
- local infos = get_nacos_services()
- if #infos == 0 then
- return
- end
local service_names = {}
- for _, service_info in ipairs(infos) do
- local data, err
+ local nodes_cache = {}
+ local had_success = false
+ local last_err
+
+ for _, service_info in ipairs(services) do
local namespace_id = service_info.namespace_id
local group_name = service_info.group_name
local scheme = service_info.scheme or ''
- local namespace_param = get_namespace_param(service_info.namespace_id)
- local group_name_param = get_group_name_param(service_info.group_name)
- local signature_param = get_signed_param(service_info.group_name,
service_info.service_name)
+ local namespace_param = get_namespace_param(namespace_id)
+ local group_name_param = get_group_name_param(group_name)
+ local signature_param = get_signed_param(group_name,
service_info.service_name)
local query_path = instance_list_path .. service_info.service_name
.. token_param .. namespace_param ..
group_name_param
.. signature_param
- data, err = get_url(base_uri, query_path)
- if err then
- log.error('get_url:', query_path, ' err:', err)
- goto CONTINUE
- end
+ local data, req_err = get_url(base_uri, query_path)
+ if req_err then
+ last_err = req_err
+ log.warn('get_url:', query_path, ' err:', req_err, ', host:',
base_uri)
Review Comment:
I improved the log information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
