lxbme commented on code in PR #13078: URL: https://github.com/apache/apisix/pull/13078#discussion_r2895514475
########## apisix/cli/file.lua: ########## @@ -90,7 +90,10 @@ local function var_sub(val) end -local function resolve_conf_var(conf) +local function resolve_conf_var(conf, enable_type_conversion) + if enable_type_conversion == nil then + enable_type_conversion = true Review Comment: I'd prefer keeping the default enable_type_conversion = true to ensure backward compatibility. Since _M.resolve_conf_var is a public function, changing the global default would silently break existing callers (like config.yaml processing) that rely on type conversion. Because this fix is specific to apisix.yaml in standalone mode, it's safer for those specific call sites to explicitly opt out by passing false. I'll also add file.resolve_conf_var(table, false) to update_config() in apisix/core/config_yaml.lua to handle runtime reloads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
