lxbme commented on PR #13078:
URL: https://github.com/apache/apisix/pull/13078#issuecomment-4012649073
Here's a summary of the changes I have pushed in the newest commit:
Code fix:
- Updated apisix/core/config_yaml.lua: update_config() now calls
file.resolve_conf_var(table, false) to disable type conversion when reloading
apisix.yaml at runtime. This was the missing call site that Copilot correctly
identified.
- Kept the default value of enable_type_conversion as true in
resolve_conf_var() to maintain backward compatibility.
Test improvements:
- Replaced openid-connect plugin with response-rewrite to eliminate external
dependencies and enable deterministic assertions.
- Changed assertions from HTTP status code checks to exact response body
matching (e.g., verifying 356002209726529540 is not converted to
3.5600220972653e+17).
- Replaced the node_listen / nginx.conf grep test with a type-sensitive
boolean test: enable_admin: ${{ENABLE_ADMIN}} with ENABLE_ADMIN=false,
verifying the admin API is actually disabled (proves string→boolean conversion
works in config.yaml).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
