shreemaan-abhishek opened a new pull request, #13319:
URL: https://github.com/apache/apisix/pull/13319

   ### Description
   
   While testing distributed rate limiting with secret references, I noticed 
that `ai-rate-limiting`, `limit-conn`, and `limit-req` were passing literal 
strings such as `"$ENV://REDIS_HOST"` to Redis instead of resolving them, even 
though `limit-count` already supported this. The root cause is that those three 
plugins never invoked `apisix.secret.fetch_secrets` on their config before 
using it. This change adds the missing `fetch_secrets` calls in the relevant 
access/log/instance-status entry points so that `$ENV://` and `$secret://` 
references in fields like `redis_host` are resolved consistently across all 
rate-limiting plugins.
   
   #### Which issue(s) this PR fixes:
   Fixes #
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to