AlinsRan commented on code in PR #2758:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2758#discussion_r3212798115
##########
internal/webhook/v1/apisixroute_webhook.go:
##########
@@ -41,19 +41,24 @@ func SetupApisixRouteWebhookWithManager(mgr ctrl.Manager)
error {
Complete()
}
-//
+kubebuilder:webhook:path=/validate-apisix-apache-org-v2-apisixroute,mutating=false,failurePolicy=fail,sideEffects=None,groups=apisix.apache.org,resources=apisixroutes,verbs=create;update,versions=v2,name=vapisixroute-v2.kb.io,admissionReviewVersions=v1,failurePolicy=Ignore
+//
+kubebuilder:webhook:path=/validate-apisix-apache-org-v2-apisixroute,mutating=false,failurePolicy=Ignore,sideEffects=None,groups=apisix.apache.org,resources=apisixroutes,verbs=create;update,versions=v2,name=vapisixroute-v2.kb.io,admissionReviewVersions=v1
Review Comment:
Ignoring it is intentional. The current installation is designed to ignore
this case; the only issue here is that the annotation is incorrect.
If we do not ignore it, then when the controller is unavailable, it may
prevent resources from being admitted or taking effect at all. For example,
during startup,
before the controller is ready, it could intercept standard resources such
as Ingress and IngressClass, even though those resources may be managed by other
controllers. That would not be the expected behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
