nic-6443 opened a new pull request, #989:
URL: https://github.com/apache/apisix-helm-chart/pull/989

   While comparing the chart against APISIX 3.17.0's built-in defaults 
(`apisix/cli/config.lua`), I found a bunch of config options that users can't 
set through values.yaml — some are hardcoded in the configmap template, some 
are not rendered at all. This PR exposes them, keeping every default identical 
to APISIX's own defaults so a render with default values produces the same 
effective config as before.
   
   Newly configurable: `apisix.showUpstreamStatusInResponseHeader`, 
`apisix.proxyProtocol.*` (the commented-out block is now a real conditional 
block, including `listen_http_port`/`listen_https_port`), `apisix.proxyCache` 
(was hardcoded; the default zones now also include the `memory_cache` zone from 
APISIX defaults, which the hardcoded block dropped — that silently broke the 
proxy-cache plugin's memory strategy), `apisix.dns.enableResolvSearchOpt`, 
`apisix.ssl.sslSessionTickets`, `apisix.nginx.workerShutdownTimeout` / 
`maxPendingTimers` / `maxRunningTimers`, a new `apisix.nginx.http.*` block 
(client timeouts, `client_max_body_size`, `real_ip_*` including the previously 
missing `real_ip_recursive`, `proxy_ssl_server_name`, upstream keepalive 
settings, `charset`, `variables_hash_max_size`), `apisix.graphql.maxSize`, and 
`etcd.watchTimeout` / `etcd.startupRetry`.
   
   One behavior fix worth calling out: `apisix.dns.resolvers` was rendered as a 
comment in the configmap, so setting it never had any effect. It now renders 
`dns_resolver` when non-empty, and the default changed from a hardcoded 
public-DNS list to `[]` (read `/etc/resolv.conf`), which matches the actual 
behavior today and is what you want in Kubernetes anyway.
   
   Also added helm-docs descriptions to every value that was missing one (~60 
of them rendered with an empty description column), so the generated README now 
documents all parameters, and fixed a couple of misplaced comments 
(`hostNetwork`, `extraVolumeMounts`).
   
   Verified by rendering the chart with default values and with the new options 
set, and running `apisix init` config validation against the 
`apache/apisix:3.17.0-ubuntu` image — both pass. Chart version bumped to 2.16.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to