nic-6443 commented on code in PR #989:
URL: https://github.com/apache/apisix-helm-chart/pull/989#discussion_r3527382013
##########
charts/apisix/values.yaml:
##########
@@ -141,41 +142,55 @@ initContainer:
tag: 1.28
autoscaling:
+ # -- Enable HorizontalPodAutoscaler for APISIX (only when useDaemonSet is
false)
enabled: false
Review Comment:
Good catch — gated hpa.yaml on `not .Values.useDaemonSet` so the HPA is no
longer rendered when the workload is a DaemonSet. Fixed in 814c236.
##########
charts/apisix/values.yaml:
##########
@@ -278,16 +303,54 @@ metrics:
apisix:
# -- Enable nginx IPv6 resolver
enableIPv6: true
+ # -- Enable HTTP/2 on the HTTP listeners
enableHTTP2: true
# -- Whether the APISIX version number should be shown in Server header
enableServerTokens: true
+ # -- When true, the upstream status is always written to the
`X-APISIX-Upstream-Status` response header; when false, it is written only for
5xx responses
+ showUpstreamStatusInResponseHeader: false
+
+ # -- PROXY Protocol configuration.
+ proxyProtocol:
+ # -- (int) The HTTP port that accepts the PROXY Protocol. It differs from
`service.http` ports and `apisix.admin` port:
+ # this port only accepts HTTP requests carrying the PROXY Protocol, while
the other ports only accept plain HTTP
+ # requests. If you enable the PROXY Protocol, you must use this port to
receive HTTP requests with it.
+ listenHttpPort:
+ # -- (int) The HTTPS port that accepts the PROXY Protocol.
Review Comment:
Agreed. The gateway Service now exposes `listenHttpPort`/`listenHttpsPort`
automatically when they are set (same pattern as the stream ports), and the
values descriptions mention it. Fixed in 814c236.
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -75,30 +75,24 @@ data:
enable_ipv6: {{ .Values.apisix.enableIPv6 }} # Enable nginx IPv6 resolver
enable_http2: {{ .Values.apisix.enableHTTP2 }}
enable_server_tokens: {{ .Values.apisix.enableServerTokens }} # Whether
the APISIX version number should be shown in Server header
+ show_upstream_status_in_response_header: {{
.Values.apisix.showUpstreamStatusInResponseHeader }} # when true all upstream
status write to `X-APISIX-Upstream-Status` otherwise only 5xx code
Review Comment:
Fixed in 814c236. (The original wording was copied verbatim from an old
APISIX config comment.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
