moonming commented on PR #3423:
URL:
https://github.com/apache/apisix-dashboard/pull/3423#issuecomment-4933161435
Post-push audit came back with **no HIGH findings**; disposition of the rest
(8dd04e85):
- **M3 (settle heuristic can race on slow runners)** — addressed: after the
GET-settle wait, both variants now assert `getByTestId('checksEnabled')` is
checked before clicking Edit. The bug's first visible symptom was this switch
reading off, so the discriminator is now deterministic rather than timing-based.
- **M1 (no stream_routes e2e variant)** and **M2 (passive-only regression
not covered)** — deliberately left as follow-ups per maintainer bandwidth; both
are cheap additions inside `form.noop-edit-preserves-checks.spec.ts` and are
listed in the test-gap section of #3417 for anyone picking it up. The
stream_routes code path itself is exercised manually and shares the fixed
producer.
- **L1 (top-level `if (d.checks)` precedence)** / **L2 (flag-derivation
duplicated in two producers)** — valid cleanups, no current caller is affected;
noted here for a future refactor.
- **L3 (`rmDoubleUnderscoreKeys` crashes on `null`)** — pre-existing,
already tracked as a checkbox in #3417 ("Data-integrity" section).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
