moonming commented on PR #3423: URL: https://github.com/apache/apisix-dashboard/pull/3423#issuecomment-4933881136
CI's e2e failure on `routes.crud-all-fields` turned out to be this PR **exposing a second, older bug** that the #3414 wipe had been masking — fixed in f413fc81: **What CI caught:** after this PR mounts the checks section correctly, editing a route whose checks only configure the *unhealthy* side (exactly what the dashboard's own create flow stores — no `active.healthy`, no `type`) made Save silently do nothing: the hand-written zod schema declared `checks.active.healthy`/`unhealthy` as **required**, while the Admin API treats both as optional. The resolver error sat on a path with no rendered input, so there was no PUT, no toast, and no visible error. On master this never surfaced because the wiped checks section kept those fields unregistered — the data-loss bug was hiding the validation bug. **Fixes:** 1. `upstreams.ts`: `active.healthy`/`active.unhealthy` → `.optional()`, matching the Admin API (the passive side already was). 2. `services`/`stream_routes` detail pages: `defaultValues` now run through `produceToNestedUpstreamForm` too — when the root flags only appear at reset time, the late-mounting passive section missed the reset values and the passive block was dropped from the PUT (root+service variants of the regression spec both discriminate this now). 3. The regression seed is now deliberately sparse (mirroring UI-stored shape) and asserts the **passive** block survives — which also covers the audit's M2. Verified locally: the previously failing `routes.crud-all-fields.spec.ts` now passes, plus upstreams/services crud suites and the strengthened regression spec. (`stream_routes` specs can't run against my local backend — stream mode disabled — CI covers those.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
