lxbme commented on issue #3417: URL: https://github.com/apache/apisix-dashboard/issues/3417#issuecomment-5087739562
Status update on the review items. Most of the list is now covered by PRs; this note is mainly about what is **not** done yet and why. ## Addressed (PRs opened, linked per area) - **Error handling / resilience** and **Data-integrity** — all items resolved (merged; a few also fixed upstream in the meantime). - **UX / IA / i18n / a11y** — dirty-form navigation guard + Cancel buttons on the add pages + conditional Edit→Cancel modal (#3443); language persistence + antd `ConfigProvider` following the app language + the delete-confirm sentence (#3440); a11y quick wins — accessible names on the header icon buttons, view-mode Monaco contrast, drawer Escape (#3442); per-route `document.title` (#3441); form TOC refresh on dynamic sections (#3439). (The "raw UTC ISO timestamps" point did not reproduce — the list columns already format via `valueType: 'dateTime'` — so no change there.) - **Architecture / hygiene** — MobX de-hostaged + dead `mobx-persist-store` dropped (#3446); the `apis/` → `components/` inverted type imports + the duplicated query-options helper (#3445); the unit test now runs in CI (#3444); and the "cheapest structural guard" for the zod layer — a contract test asserting it is looser-or-equal to the gateway's own per-resource schema (#3449), which already caught the upstream `scheme` enum missing `kafka`, now fixed (#3450). - **Test-suite gaps** — round-trip invariant (#3448); masking assertion outside the settings modal (#3447); mutation-failure feedback extended to update / delete / network-level (#3447); the `zOneOf` both/neither quadrants (#3447); i18n key-parity unit test (#3447). ## Still to do **Dual UI library — replace `ProTable` with a Mantine-native table.** A migration across all 12 list pages plus the one `EditableProTable`, removing `antd` + `@ant-design/pro-components` (the largest vendor chunk). Big enough that the replacement approach (a Mantine table library vs. a hand-rolled table) is worth agreeing before starting. **Submit pipeline — invert "strip-then-restore" to dirty-fields-based submission.** This is the root of several data-integrity items that were each patched individually. Inverting it touches every form's submit path and the shared producer pipeline, so it has a large blast radius and wants its own design pass rather than being folded into an unrelated PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
